New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guests to use source control diffing features in VS and VS Code #36

Closed
Chuxel opened this Issue Jan 12, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@Chuxel
Collaborator

Chuxel commented Jan 12, 2018

Note that developers starting the collaboration session (hosts) do not have this limitation. It is specific to guests joining a session.

Currently source control features like those found in the VS Team Explorer and the VS Code Source Control tabs do not function for guests joining a collaboration session as they rely on local files to work. In addition, source control diffing features suffer from similar problems regardless of where they are initiated.

We should consider doing the extra work required to allow guests to use source control diffing in VS and VS Code to help owners isolate issues if there is sufficient interest in the scenario.

@Chuxel Chuxel added the area: diffing label Feb 7, 2018

mschulz-msft pushed a commit that referenced this issue Apr 24, 2018

Merge pull request #36 from MicrosoftDocs/master
Update linux directions
@lostintangent

This comment has been minimized.

Collaborator

lostintangent commented Dec 5, 2018

This has now been addressed in the latest Live Share release! 🔥In VS Code, this works out of the box (guests will see a read-only view of the Source Control tab), and in VS, you'll need to use VS2019 Preview + the Pull Requests extension. Let us know if you have any questions/issues. Thanks again for the feedback!

@rojopolis

This comment has been minimized.

rojopolis commented Dec 6, 2018

I see that this feature was released in https://github.com/MicrosoftDocs/live-share/releases/tag/v0.3.1011 however the feature either isn't available, or it's unclear how to enable it. I don't see any configuration option to enable this. Do I need to (further) RTFM, or is this not working?
I'm writing an article on remote collaboration with VSCode today and I'd love to be able to include this feature!

@lostintangent

This comment has been minimized.

Collaborator

lostintangent commented Dec 6, 2018

@rojopolis We just realized that we forgot to move this feature out of the experimental stage. We're going to update this now and release a fix. In the meantime, if you set the liveshare.features setting to experimental, then you'll see the list of changed files + diffs show up on the guest side via the Source Control tab. Apologies for the confusion on our end!

@lostintangent

This comment has been minimized.

Collaborator

lostintangent commented Dec 6, 2018

@rojopolis We just shipped the update to the marketplace that enables shared source control state with guests. Apologies for that mistake, and let us know if you run into any other issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment