Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Art Show sales form is passing through floating-point errors #532

Open
kitsuta opened this issue Dec 8, 2021 · 1 comment
Open

Art Show sales form is passing through floating-point errors #532

kitsuta opened this issue Dec 8, 2021 · 1 comment

Comments

@kitsuta
Copy link
Collaborator

kitsuta commented Dec 8, 2021

We discovered at-con that, for some attendees, the Art Show sales form (/art_show_admin/pieces_bought) is passing floats, not integers, to its page handler. Said floats would look like, say, "59.00000025", indicating floating-point math errors. We fixed the issue using aggressive casting on the backend (see #525 and #527), but we need to figure out where we're doing math with floats and switch that to using integers.

@kitsuta
Copy link
Collaborator Author

kitsuta commented Mar 5, 2022

We should consider investigating this as a must-have as it might be a sign of something serious. Investigation estimate: 1-2 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant