Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Real world security] Http connections possible to local server network #2365

Closed
JLLeitschuh opened this issue May 3, 2017 · 3 comments
Closed

Comments

@JLLeitschuh
Copy link
Contributor

I haven't looked at the code to see if this has already been guarded against but I want to bring it to someone's attention in case it hasn't been.

There are certain things you may not want your server users able to poke around with. For example, most routers are running on 192.168.1.1. I really don't want people on my server able to poke around and access my router's admin console (I have a password but let's be honest here, how many people actually change the default password).

Many people running servers probably aren't using a hosting service and having http/tcp enabled currently gives players full access to the server's internal network.

It's a simple bit of code to have your users tinkering with the server hosters router.

I opened a similar issue against the computercraft mod.
dan200/ComputerCraft#170

@Pwootage
Copy link
Contributor

Pwootage commented May 3, 2017

There is a domain blacklist, and by default it blocks local IPs

(e.g. https://github.com/MightyPirates/OpenComputers/blob/master-MC1.7.10/src/main/resources/application.conf#L927-L946 )

@magik6k
Copy link
Contributor

magik6k commented May 4, 2017

As noted above, this is not a possible by default.

@magik6k magik6k closed this as completed May 4, 2017
@JLLeitschuh
Copy link
Contributor Author

Good. Thanks! I just wanted to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants