New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose computer.beep(pattern) #2716

Closed

Inari-Whitebear opened this issue Jan 2, 2018 · 1 comment

Milestone

Contributor

Inari-Whitebear commented Jan 2, 2018 •

edited

OpenComputers/src/main/java/li/cil/oc/api/machine/Machine.java

Lines 180 to 181 in d5f1280

    
                * The passed pattern must consist of dots (<tt>.</tt>) and dashes (<tt>-</tt>), 
        
                * where a dot is short tone, and a dash is a long tone.

This doesn't seem to be exposed to the LUA Api, would be cool.

As seen here:

Member

payonel commented Jan 2, 2018

good catch, @Inari-Whitebear
the change will be here: https://github.com/MightyPirates/OpenComputers/blob/master-MC1.7.10/src/main/scala/li/cil/oc/server/machine/Machine.scala#L423
right now that code is assuming nil or int, needs to allow for the string pattern too

payonel added this to the v1.7.3 milestone

payonel closed this as completed in

436bd18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment