Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require sorted order of SvcFieldParams? #96

Closed
bemasc opened this issue Dec 17, 2019 · 3 comments
Closed

Require sorted order of SvcFieldParams? #96

bemasc opened this issue Dec 17, 2019 · 3 comments

Comments

@bemasc
Copy link
Collaborator

bemasc commented Dec 17, 2019

The order of the SvcFieldParams is not meaningful. Should we require (and enforce?) that they appear in key order? This makes serialization more annoying to implement, but also removes a source of entropy that could be used to fingerprint authoritative implementations.
@moonshiner
Copy link
Contributor

no. they should be easy to sort when they arrive, yes?

@MikeBishop
Copy link
Owner

Done.

@tfpauly
Copy link
Contributor

tfpauly commented May 29, 2020

Fixed in #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moonshiner @bemasc @tfpauly @MikeBishop