Urls with query string are not working correctly. This fixes it. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Node documentation: path <string> Request path. Should include query string if any. E.G. '/index.html?page=12'. An exception is thrown when the request path contains illegal characters. Currently, only spaces are rejected but that may change in the future. Default: '/'.
|
Great thanks !! |
|
Hello @ombr . I'm sorry I forgot to mention that 7.1.0 was released last week. |
|
Great thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting 403 from aws s3 as query_string are not passed through in the node fetch polyfill.
With this PR, I am able to parse the exifs on files stored on AWS S3 with presigned_urls. (It is another but simpler use case of #57)
From Node documentation:
path Request path. Should include query string if any. E.G.
'/index.html?page=12'. An exception is thrown when the request path
contains illegal characters. Currently, only spaces are rejected but
that may change in the future. Default: '/'.