Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note: performance issue? #51

Closed
clemens-tolboom opened this issue Apr 14, 2021 · 7 comments
Closed

Note: performance issue? #51

clemens-tolboom opened this issue Apr 14, 2021 · 7 comments
Assignees
Labels
godot related issue Its a bug by Godot engine and can't be fixed by GdUnit

Comments

@clemens-tolboom
Copy link
Contributor

I'm testing with Godot-3.3-rc8 and ran into Slow Create Resource Dialog in a project with a lot of class_names having only this plugin.

We have ~240 class_name items.

image

So this is not a bug but it takes ~10 sec to get this Resource dropdowns to open.

It seems not being fixed before Godot-4 :-(

@clemens-tolboom
Copy link
Contributor Author

Nice label ~"godot related issue"

@MikeSchulze
Copy link
Owner

Thanks for reporting this.
You ok to close this because it is a Godot related bug and is not relates to GdUnit3 plugin?

@clemens-tolboom
Copy link
Contributor Author

Remove the bug label and yes OK to close.

@MikeSchulze MikeSchulze removed the bug Something isn't working label Apr 14, 2021
@clemens-tolboom
Copy link
Contributor Author

Wow ... it is only slow when the plugin is not enabled ... can you test that yourself.

@MikeSchulze
Copy link
Owner

MikeSchulze commented Apr 14, 2021

Ok, so it is reproducible by enabling/disabling the GdUnit3 plugin?
So means my plugin fixes a kind of this bug ? ;) ???

Can you please add the steps to reproduce.

A example project would be nice

@MikeSchulze
Copy link
Owner

After a quick analysis, I suspect it's because I'm scanning for registered classes in my plugin.

var script_classes:Array = ProjectSettings.get_setting("_global_script_classes") as Array

Maybe this pre caches the classes.

Can you try this as a workaround?

@clemens-tolboom
Copy link
Contributor Author

Having the plugin disabled/not enabled produce this (~20secs) issue.

After enabling the plugin performance improves by a factor of 10 (~2secs).

  1. Enable gdUnit3
  2. Open a Scene
  3. Add a node
  4. Set it's Material / Theme (just click the dropdown)
  5. Disable gdUnit3
  6. Set it's Material / Theme (just click the dropdown)

So this project is not the problem. It's Godot scanning for Resource files according to godotengine/godot#34205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
godot related issue Its a bug by Godot engine and can't be fixed by GdUnit
Projects
None yet
Development

No branches or pull requests

2 participants