Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-88: Move internal tests under one directory for easy install exclusion #88

Closed
cgbeutler opened this issue Jun 9, 2021 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@cgbeutler
Copy link

Is your feature request related to a problem? Please describe.
When installing from the AssetLib, you can choose not to install certain folders. What can be excluded is currently unclear and spread out.

Describe the solution you'd like
Most of the AssetLib assets have a top-level folder for examples and tests, making it easy to exclude those folders for a minimal install. It would be nice if we could move all the test folders to a common one for easy exclusion. This may also make it easier when updating gdUnit3, as the test folder will likely remain unchanged.

Describe alternatives you've considered
N/A

Additional context
N/A

@MikeSchulze
Copy link
Owner

MikeSchulze commented Jun 10, 2021

Hi @cgbeutler thanks for your feedback.

By default all internal tests are located in one directory at addons\gdUnit3\test i think you mean the additional test located at addons\GdCommons\utils\test and addons\GdCommons\DateTime\test ?
I currently working on a integrated upgrade tool that will solve this problem.
Additional i will check what i can do to exclude tests by default from downloading without break the CI.

@MikeSchulze MikeSchulze self-assigned this Jun 10, 2021
@MikeSchulze MikeSchulze added the enhancement New feature or request label Jun 10, 2021
@MikeSchulze MikeSchulze added this to To Do in GdUnit3 via automation Jun 10, 2021
@MikeSchulze MikeSchulze added this to the v1.0.0 milestone Jun 10, 2021
@MikeSchulze MikeSchulze changed the title Move internal tests under one directory for easy install exclusion GD-88: Move internal tests under one directory for easy install exclusion Jun 10, 2021
@MikeSchulze MikeSchulze moved this from To Do to In progress in GdUnit3 Jun 10, 2021
@MikeSchulze
Copy link
Owner

On next AssetLib version the test will be excluded see https://github.com/MikeSchulze/gdUnit3/blob/master/.gitattributes

GdUnit3 automation moved this from In progress to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GdUnit3
  
Done
Development

No branches or pull requests

2 participants