Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To do list task #1

Merged
merged 14 commits into from Apr 27, 2022
Merged

To do list task #1

merged 14 commits into from Apr 27, 2022

Conversation

Mikelobi
Copy link
Owner

In this project I :

  • Setup webpack to generate output source file for HTML, CSS, Javascript, and images.
  • Added To-do list items dynamically with JavaScript.

Copy link

@andersonlebon andersonlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mikelobi

Good job so far! I know you have worked hard on making this milestone But There are some issues that you still need to work on to go to the next project but you are almost there!

almost-there

To highlight 🍾

  • All linters are passing ✔️
  • Good commit history ✔️
  • Good PR description ✔️

Required Changes ♻️

  • Kindly check comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/index.js Outdated
Comment on lines 42 to 46
// let radioBox = document.createElement('input');
// radioBox.type = 'checkbox';
// listItem.appendChild(radioBox);
// listItem.textContent = list.description;
// ;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly remove commented code so that your file will be more clear and clean

Copy link

@aimemalaika aimemalaika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mikelobi,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

133591850-fdcb7dd3-dd7a-4274-81e7-0e59434148f7

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Mikelobi Mikelobi merged commit 9400456 into master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants