Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive list #3

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Interactive list #3

wants to merge 10 commits into from

Conversation

Mikelobi
Copy link
Owner

In this branch:

  • use webpack to bundle JavaScript.
  • check correct github workflow.
  • check for proper ES6 syntax.
  • use ES6 modules to write modular JavaScript.
  • implement a function for the "Clear all completed" button

Copy link

@roshan-bajgain roshan-bajgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👏

Hi there,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight:

  • The Pull Request has a proper title and description. ✔️
  • You have added a descriptive Readme file. Good Job. ✔️
  • There is no linter error at present. ✔️
  • Project has met all the technical aspects you needed for this project. Keep rocking! ✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of code reviews per project which you can see from your dashboard. If you think that the code review was not fair, you can request a second opinion using this form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants