Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Indirect Proxy: Reserve space to prevent jumps when graphs appear #131

Closed
friesoft opened this issue Mar 13, 2018 · 4 comments

Comments

@friesoft
Copy link
Contributor

Expected Behavior

Reserve the space needed for graphs while they are loading (placeholder image? spinner?)

Current Behavior

Currently the headline "Performance Graph" and the timechooser is shown and while scrolling/looking/clicking through the page the graphs appear and move everything down possibly leading to unwanted clicks.

Possible Solution

If the height of the graphs is specified I guess the div "icinga-module module-grafana" could be set to this size to already preoccupy the needed space.

Steps to Reproduce (for bugs)

Use indirect proxy and open services/hosts containing graphs - the page content moves down as soon as the graphs appear.

Context

Could lead to wrong annoying behaviour (trying to click on "schedule downtime" - graphs appear - clicked on one of the graphs jumping into a grafana tab

Your Environment

  • Icinga Web 2 Grafana version (System - About): master (c185828)
  • Icinga Web 2 version and modules (System - About): 2.5.1
  • Version used (icinga2 --version): 2.8.1-1
  • Operating System and version: Red Hat 7.4
@Mikesch-mp
Copy link
Owner

Hmm have to read if there is a solution for this.

@Mikesch-mp Mikesch-mp added this to the 1.2.1 milestone Mar 13, 2018
@Mikesch-mp
Copy link
Owner

Was easier then i thought first :)

@friesoft
Copy link
Contributor Author

Nice :) Will test tomorrow, but diff looks like I would probably have done it - but I'm all but an expert on CSS 😆
Thanks! 😃

@friesoft
Copy link
Contributor Author

Works for me 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants