-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional use host_display_name instead of host_name in call to Grafana #133
Comments
Hello @idMaxCZ , if you want to set it via customvar option you have to create a custom var that points to the display_name like
then for the graph configuration set custom variables like this
|
Thank you for your answer. I understand there can be problem with duplicates, this is reason why i recommend this as optional option in module configuration. Default as host_name with possibility change to display_name. I am little bit stacked now, because I have named measurements by display_name and host_name is not present in my influxDB. I already updated Grapher.php for this, but its my hack and every version of plugin I have update this file again. FYI: We have controlled Icinga hosts by CMDB and there is protection mechanism for duplicates. This is reason, why I am not afraid |
Going for display_name is dangerous here, as you cannot guarantee the correctly selected graph for it. I don‘t think that such a special case should be handled with yet another config option either. Imho the module already has too many config settings and behaviours, impossible to test them all to endure stable releases. |
I totally understand, our environment is probably specific. |
Feature request:
Please add combobox option to Module configuration for optional change var-hostname source. In present version of module is everytime used host_name host variable for call grafana. I suggest two options - host_name as default and host_display_name as optional way.
We have stored data in influx under display_names because host_name are humen unreadable strings from our configuration management database.
Example current:
.../dashboard-solo/db/icinga2-default?var-hostname=srv154848754878&var-serv...
Expected state:
.../dashboard-solo/db/icinga2-default?var-hostname=testmachine_displayname&var-serv...
Icinga host object:
object Host "srv154848754878" {
import "generic-host"
display_name = "testmachine_displayname"
address = "8.8.8.8"
}
Thank you
The text was updated successfully, but these errors were encountered: