Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor stream handling #5

Open
MikkelHJuul opened this issue Apr 15, 2021 · 0 comments
Open

Poor stream handling #5

MikkelHJuul opened this issue Apr 15, 2021 · 0 comments

Comments

@MikkelHJuul
Copy link
Owner

MikkelHJuul commented Apr 15, 2021

If for some reason an error is returned when trying to send a message for *Many-RPCs and *Range-RPCs the error is logged and the request is not cancelled. This may lead to issues.

go func() {
   for kv := range out {
		if err := sender.Send(kv); err != nil {
			log.Warn(err)
		}
	}
	cancel()
} ()

should be handled using "golang.org/x/sync/errgroup".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant