Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More correct at the LLVM level? #30

Open
ChrisRackauckas opened this issue Jun 3, 2024 · 1 comment
Open

More correct at the LLVM level? #30

ChrisRackauckas opened this issue Jun 3, 2024 · 1 comment

Comments

@ChrisRackauckas
Copy link

Does this implementation give false positives? I would think you would need to run this after optimizations, such as DCE, in order for this to not have false positives?

@MilesCranmer
Copy link
Owner

It relies on Base.promote_op to do the inference. So whatever optimizations are used for Base.promote_op will apply here.

I haven't found a false positive but I am sure they exist. For example I ran into #27 but it turned out to be a real typeof instability due to how Core.kwcall works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants