Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Input chips without an apply button are hidden after every input #513

Closed
buehlefs opened this issue May 17, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working planned This issue is being planned in iteration

Comments

@buehlefs
Copy link

Describe the bug
Try to edit an inline math node or a footnote reference (e.g. https://milkdown.dev/online-demo). The input chip will close after every single input. To show the input again to input the next character one needs to click on another node first before clicking on the math node.

To Reproduce

  1. Go to https://milkdown.dev/online-demo
  2. Click on an inline math element (or a footnote)
  3. Try to edit the element
  4. The input chip hides itself after the first keypress

Expected behavior
The input chip should not hide itself until the user clicked outside.

Desktop (please complete the following information):

  • OS: windows
  • Browser vivaldi (chromium)

Additional context
Debugging the problem suggests, that the view.hasFocus() function of the node returns false after an input which in turn hides the input chip.

@buehlefs buehlefs added the bug Something isn't working label May 17, 2022
@Saul-Mirone Saul-Mirone added the planned This issue is being planned in iteration label May 17, 2022
@Saul-Mirone
Copy link
Member

I'll fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned This issue is being planned in iteration
Projects
None yet
Development

No branches or pull requests

2 participants