Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature command edit/update surveys and their components #53

Closed
berkingurcan opened this issue May 31, 2024 · 8 comments · Fixed by #56
Closed

feature command edit/update surveys and their components #53

berkingurcan opened this issue May 31, 2024 · 8 comments · Fixed by #56
Assignees
Labels
approved-for-product enhancement New feature or request PR 56 Survey Bot A bot to summarize and categorize surveys tested!

Comments

@berkingurcan
Copy link
Collaborator

Is there a difference between editing and updating? @es92 @CristinaEche
If there is, can you give an example?

@CristinaEche
Copy link
Collaborator

CristinaEche commented May 31, 2024

Hello @berkingurcan, it is the same, the idea is to be able to retrieve the modal of a published survey and edit or update any information previously created.

CC: @es92

@berkingurcan
Copy link
Collaborator Author

Okay!

@CristinaEche CristinaEche added enhancement New feature or request Survey Bot A bot to summarize and categorize surveys labels Jun 4, 2024
@CristinaEche
Copy link
Collaborator

We are testing 5 scenarios:

1- editing questions and descriptions without responses - single and multi response testing- OK
2- editing questions and descriptions with responses single and multi - with responses- OK
3- Multiresponse: delete questions - if only one questions it turns into single question modal- OK
4- Multiresponse : add questions - not able to do it so far- TBC

CC: @es92

@CristinaEche
Copy link
Collaborator

Evidence:

Multiresponse: delete questions - if only one questions it turns into single question modal

Screenshot 2024-06-04 at 14 26 22

Multiresponse changing description from 123 to 456

Screenshot 2024-06-04 at 14 19 06 Screenshot 2024-06-04 at 14 18 29 Screenshot 2024-06-04 at 14 17 15

Videos of single response testing

Screen.Recording.2024-06-04.at.13.58.56.mov
Screen.Recording.2024-06-04.at.13.43.09.mov

@berkingurcan
Copy link
Collaborator Author

TODO!: I have an error while adding more questions to initial question number while editing:

Unhandled exception: ValidationError > s.string
  Expected a string primitive

  Received:
  | undefined

    at _StringValidator.handle (/Users/berkingurcan/Documents/gptSurveySummarizer/node_modules/@sapphire/shapeshift/src/validators/StringValidator.ts:23:73)
    at _StringValidator.parse (/Users/berkingurcan/Documents/gptSurveySummarizer/node_modules/@sapphire/shapeshift/src/validators/BaseValidator.ts:103:2)
    at TextInputBuilder.setValue (/Users/berkingurcan/Documents/gptSurveySummarizer/node_modules/@discordjs/builders/src/components/textInput/TextInput.ts:117:36)
    at <anonymous> (/Users/berkingurcan/Documents/gptSurveySummarizer/src/commands/handleRespondButton.ts:68:12)
    at Array.map (<anonymous>)
    at handleRespondButton (/Users/berkingurcan/Documents/gptSurveySummarizer/src/commands/handleRespondButton.ts:62:8)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Client.<anonymous> (/Users/berkingurcan/Documents/gptSurveySummarizer/src/bot.ts:110:9)

@CristinaEche
Copy link
Collaborator

Multiresponse editing and question deletion tested one more time, here the evidences:

Screenshot 2024-06-05 at 14 36 03
Screen.Recording.2024-06-05.at.14.37.56.mov
Screen.Recording.2024-06-05.at.14.40.32.mov

@berkingurcan
Copy link
Collaborator Author

TODO!: I have an error while adding more questions to initial question number while editing:

Unhandled exception: ValidationError > s.string
  Expected a string primitive

  Received:
  | undefined

    at _StringValidator.handle (/Users/berkingurcan/Documents/gptSurveySummarizer/node_modules/@sapphire/shapeshift/src/validators/StringValidator.ts:23:73)
    at _StringValidator.parse (/Users/berkingurcan/Documents/gptSurveySummarizer/node_modules/@sapphire/shapeshift/src/validators/BaseValidator.ts:103:2)
    at TextInputBuilder.setValue (/Users/berkingurcan/Documents/gptSurveySummarizer/node_modules/@discordjs/builders/src/components/textInput/TextInput.ts:117:36)
    at <anonymous> (/Users/berkingurcan/Documents/gptSurveySummarizer/src/commands/handleRespondButton.ts:68:12)
    at Array.map (<anonymous>)
    at handleRespondButton (/Users/berkingurcan/Documents/gptSurveySummarizer/src/commands/handleRespondButton.ts:62:8)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Client.<anonymous> (/Users/berkingurcan/Documents/gptSurveySummarizer/src/bot.ts:110:9)

Solved.

@CristinaEche
Copy link
Collaborator

CristinaEche commented Jun 10, 2024

FYI: detected that we cannot use "-" in a survey title. It let's us create the survey but if we want to edit the survey it show an error. usage of "-" will be restricted.

@CristinaEche CristinaEche added PR 56 Pending product approval Ready to deploy but pending for approval labels Jun 10, 2024
@CristinaEche CristinaEche linked a pull request Jun 10, 2024 that will close this issue
@CristinaEche CristinaEche added approved-for-product and removed Pending product approval Ready to deploy but pending for approval labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-product enhancement New feature or request PR 56 Survey Bot A bot to summarize and categorize surveys tested!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants