Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and address TODOs in snarky_js_bindings_lib #10554

Closed
mitschabaude opened this issue Mar 21, 2022 · 1 comment
Closed

Clean up and address TODOs in snarky_js_bindings_lib #10554

mitschabaude opened this issue Mar 21, 2022 · 1 comment
Assignees
@mitschabaude

Comments

@mitschabaude
Copy link
Member

  • remove unused code
  • split lib apart into more digestible chunks, such as
    • tools for circuit creation (Field, Bool, Group, Circuit...)
    • protocol-related code (party hashing, mock transaction API, ...)
  • if needed, more robust conversion of JS arrays to OCaml Cvars
  • Think about how to address these TODOs and track in separate issues:
    • better handling of error messages
    • fix Field comparisons for small negative values (UInt64.lt Bug o1-labs/o1js#101)
    • add Group.endoScale
    • fix or remove async circuit##.runAndCheck
@mitschabaude mitschabaude self-assigned this Mar 21, 2022
@mitschabaude mitschabaude mentioned this issue Mar 21, 2022
Merged
@mitschabaude
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitschabaude mitschabaude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitschabaude