Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ocaml-extlib to upstream #10953

Closed
9 tasks done
Firobe opened this issue May 13, 2022 · 1 comment
Closed
9 tasks done

Upgrade ocaml-extlib to upstream #10953

Firobe opened this issue May 13, 2022 · 1 comment
Assignees
@Firobe

Comments

@Firobe
Copy link
Contributor

Firobe commented May 13, 2022 •
edited
Loading

It appears that extlib is pinned to a local version because some changes were needed (removing base64 from the default build). These changes are now upstreamed, and we can get rid of the submodule.

  • Unpin
  • Upgrade
  • Check build consistency
  • Add to switch
  • Remove from pin script (remove async_unix as well)
  • Remove submodule
  • Remove scripts/setup-opam.sh
  • Merge
  • Suggest deletion/archival of the pin repository

Needed for #10940
@Firobe Firobe self-assigned this May 13, 2022
@Firobe Firobe added the Tweag label May 13, 2022
@Firobe Firobe mentioned this issue May 13, 2022
Merged
@Firobe
Copy link
Contributor Author

Firobe commented May 16, 2022

Done.

@Firobe Firobe closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Firobe Firobe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Firobe