Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binable.of_binable1_without_uuid to binable version linter. #11055

Closed
psteckler opened this issue May 23, 2022 · 3 comments
Closed

Add Binable.of_binable1_without_uuid to binable version linter. #11055

psteckler opened this issue May 23, 2022 · 3 comments
Assignees

Comments

@psteckler
Copy link
Member

See if there are corresponding multi-argument functors also to be added.

@psteckler psteckler created this issue from a note in Snapps protocol eng (To do) May 23, 2022
@psteckler psteckler self-assigned this May 23, 2022
@Firobe
Copy link
Contributor

Firobe commented May 23, 2022

The corresponding Binable.Of_binable_**with**_uuid should be added as well. If relevant, the Of_stringable functors may also be necessary to consider.

@psteckler
Copy link
Member Author

The change is needed in ppx_version, in the file tools/print_binable_functors.

@psteckler
Copy link
Member Author

The with_uuid functors should not be used in the Mina code. There's a claim that the without_uuid functors produce stable (de)serializations, so one can infer the with_uuid ones may be unstable.

We can lint for the presence of those functors in code as it's being written, or use the CI linter for that purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants