Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification fails on proofs which merge 1 previous proof, after conversion with Side_loaded.of_proof #11389

Closed
mitschabaude opened this issue Jun 27, 2022 · 2 comments

Comments

@mitschabaude
Copy link
Member

mitschabaude commented Jun 27, 2022

impact: this would currently prevent these proofs from being accepted in transactions. for example, the mastermind example would probably not work when deployed on-chain

to reproduce, run the snarkyjs example src/examples/program.ts, and observe the bad verify: dlog_check messages

@joseandro
Copy link
Member

@mitschabaude has this work been deprioritized?

@mitschabaude
Copy link
Member Author

mitschabaude commented Oct 28, 2022

@joseandro Not to my knowledge! It has to be fixed at least before the HF, otherwise we won't fully support recursion in user circuits

There's this PR, which has been open for a couple of weeks, which addresses the issue:
#11698
It seems to have a couple of integration tests failing still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants