Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Mina Signer(Client SDK) to sign account updates #12014

Closed
ymekuria opened this issue Oct 20, 2022 · 2 comments · Fixed by o1-labs/o1js#705
Closed

Allow Mina Signer(Client SDK) to sign account updates #12014

ymekuria opened this issue Oct 20, 2022 · 2 comments · Fixed by o1-labs/o1js#705
Assignees
@mitschabaude
Labels
berkeley-incentivized berkeley-rampup P2 to-discuss o1 zkApps Product

Comments

@ymekuria
Copy link

Currently Mina Signer only signs the feepayer part of transactions and not other account updates. This will allow wallets to be able to sign other account updates.
@maht0rz
Copy link

maht0rz commented Nov 25, 2022

Could we also add .signFields as discussed here? aurowallet/auro-wallet-browser-extension#16

@mitschabaude
Copy link
Member

@maht0rz yes would be nice, but is a completely separate issue IMO

@mitschabaude mitschabaude added the to-discuss o1 zkApps Product label Jan 19, 2023
@mitschabaude mitschabaude mentioned this issue Jan 19, 2023
Merged
@mitschabaude mitschabaude self-assigned this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitschabaude mitschabaude

Labels
berkeley-incentivized berkeley-rampup P2 to-discuss o1 zkApps Product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mina-signer: sign account updates o1-labs/o1js
5 participants
@ymekuria @shimkiv @maht0rz @mitschabaude @aneesharaines