Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replayer should not use mod to calculate when next checkpoint should be written #13401

Closed
psteckler opened this issue Jun 14, 2023 · 1 comment
Closed

Replayer should not use mod to calculate when next checkpoint should be written #13401

psteckler opened this issue Jun 14, 2023 · 1 comment

Comments

@psteckler
Copy link
Member

Many slots do not contain blocks, so using mod can skip checkpoints.

Instead, have a current slot target, and when the target is met or exceeded, write the checkpoint, and reset the target.
@psteckler psteckler mentioned this issue Jun 14, 2023
Merged
@psteckler
Copy link
Member Author

Fixed in #13406.

@jrwashburn jrwashburn mentioned this issue Mar 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psteckler