Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildkite CI: Cull unnecessary jobs #4990

Closed
bkase opened this issue Jun 2, 2020 · 3 comments
Closed

Buildkite CI: Cull unnecessary jobs #4990

bkase opened this issue Jun 2, 2020 · 3 comments

Comments

@bkase
Copy link
Member

bkase commented Jun 2, 2020

I think we have CI jobs or portions of jobs that we don't need to move over to Buildkite, but can actually just remove entirely.

This issue attempts to justify removing some of them. Please comment if you disagree with removing any of the pipelines here, or think we should remove others.

  1. Tracetool -- I think this has been replaced by another tool at this point, but I'm not sure, cc @emberian
  2. The nightly *medium_curves jobs: specifically, test-unit-medium-curves -- I don't think we've been keeping up-to-date checking up on these jobs. For the former, I recall us frequently noticing it breaking but it being unrelated to us actually introducing issues. For the latter, this will be replaced by the network validation system (and new integration tests right?)
  3. All existing integration test pipelines (we're replacing with the new integration testing system)
  4. The steps within jobs that redundantly upload artifacts to both AWS and Google Cloud -- let's just upload in Google Cloud through the buildkite tool. Existing places that only upload to S3 (including the snark keys/genesis ledger caching logic) can remain.
@bkase
Copy link
Member Author

bkase commented Jun 3, 2020

  1. Update-branch-protection -- This job looks at test.py and decides which tests are required and then subsequently updates GitHub's required tests. We no longer need this because in the new world, all tests are required. If a test is failing but we want to keep it in our suite, it should be in the quarantine suite which "fails" with a green success instead.

@emberian
Copy link
Member

tracetool is still necessary.

@O1ahmad
Copy link
Contributor

O1ahmad commented Aug 18, 2020

@emberian @bkase worth creating a Buildkite job for building and uploading tracetool as a GCS artifact (or something along those lines) or should the job just build the tool? Seems like in CircleCI the tool is just built (without being uploaded anywhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants