Clean up test deps and add tests for urls

setup.py

@@ -53,11 +53,6 @@
         ],
         tests_require=[
             'django',
-            'coverage',
-            'pylint',
-            'pep8',
-            'pyflakes',
-            'coveralls'
         ],
         extras_require={
             'dev': ['check-manifest'],

src/django_saml2_pro_auth/urls.py

@@ -5,10 +5,16 @@
 
 from . import views
 
-# pragma: no cover
 SAML_ROUTE = settings.SAML_ROUTE
-AUTH = r'^' + SAML_ROUTE + '$'
-METADATA = r'^' + SAML_ROUTE + 'metadata/$'
+
+if SAML_ROUTE.strip()[-1] == '/':
+    SAML_ROUTE = SAML_ROUTE.rstrip('/')
+
+if SAML_ROUTE.strip()[0] == '/':
+    SAML_ROUTE = SAML_ROUTE.lstrip('/')
+
+AUTH = r'^' + SAML_ROUTE + '/$'
+METADATA = r'^' + SAML_ROUTE + '/metadata/$'
 
 urlpatterns = [
     url(AUTH, views.saml_login, name='saml2_auth'),

tests/test_urls.py

@@ -0,0 +1,59 @@
+from django.test import TestCase
+from django.conf import settings
+from django.urls import resolve, reverse
+from django.test.utils import override_settings
+
+import onelogin
+
+
+from . import init_test_settings
+
+test_settings = init_test_settings()
+
+try:
+    settings.configure(**test_settings)
+except RuntimeError:
+    # already configured in other test
+    pass
+
+settings.SAML_ROUTE = '/sso/saml'
+settings.ROOT_URLCONF = 'django_saml2_pro_auth.urls'
+
+from django_saml2_pro_auth.urls import urlpatterns, SAML_ROUTE, AUTH, METADATA
+
+class TestURLS(TestCase):
+    def test_url_constants(self):
+        self.assertEqual(SAML_ROUTE, 'sso/saml')
+        self.assertEqual(AUTH, '^sso/saml/$')
+        self.assertEqual(METADATA, '^sso/saml/metadata/$')
+
+
+    def test_url_names_with_start_forward_slash(self):
+        self.assertEqual(reverse('saml2_auth'), '/sso/saml/')
+        self.assertEqual(reverse('metadata'), '/sso/saml/metadata/')
+
+    def test_url_resolving_with_start_forward_slash(self):
+        self.assertEqual(resolve('/sso/saml/').view_name, 'saml2_auth')
+        self.assertEqual(resolve('/sso/saml/metadata/').view_name, 'metadata')
+
+    @override_settings(SAML_ROUTE='/sso/saml/')
+    def test_url_names_with_end_forward_slash(self):
+        self.assertEqual(reverse('saml2_auth'), '/sso/saml/')
+        self.assertEqual(reverse('metadata'), '/sso/saml/metadata/')
+
+    @override_settings(SAML_ROUTE='/sso/saml/')
+    def test_url_resolving_with_end_forward_slash(self):
+        self.assertEqual(resolve('/sso/saml/').view_name, 'saml2_auth')
+        self.assertEqual(resolve('/sso/saml/metadata/').view_name, 'metadata')
+
+    @override_settings(SAML_ROUTE='sso/saml')
+    def test_url_names_with_no_rl_slashes(self):
+        self.assertEqual(reverse('saml2_auth'), '/sso/saml/')
+        self.assertEqual(reverse('metadata'), '/sso/saml/metadata/')
+
+    @override_settings(SAML_ROUTE='sso/saml')
+    def test_url_resolving_with_no_rl_slashes(self):
+        self.assertEqual(resolve('/sso/saml/').view_name, 'saml2_auth')
+        self.assertEqual(resolve('/sso/saml/metadata/').view_name, 'metadata')
+
+