-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA with production #8
Conversation
Please provide some documentation on the contents of the output files. The hdf5 file is currently a large 4d array. From context it is clear to me which dimension corresponds to the facies, time step, and spatial coordinates. However, I think it'd be best of this info is directly associated with the array, so the interpretation of the data independent is not dependent on the contextual knowledge of the examiner |
I run into an issue while precompiling the dependencies. I get the error
which seems to be due to a hardcoded path in manifest.toml |
This is so annoying. I'm guessing VS Code is adding this entry |
I had the same but other than giving an error message it doesn't actually interfere with running, at least the examples 🤷♀️ |
One weird thing that happens to me is if I run:
and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, but are the plots the benchmark for comparing the output for different settings of CA? I found the plot very hard to read but maybe I miss something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just not done yet ;)
Adjust README
|
|
I think some of these things we can fix ourselves if @jhidding is comfortable with that? |
Some of these have little to do with this PR. I'll fix those items that do, then we merge into main and move on from there? |
Good for me! I asked Nick and @xyl96 for review this way because I wanted them to confirm that they can run everything. We need a clear yes or no, guys 😉 if you have issues running anything this is the moment to share that 😊 |
I'm not sure what is considered part if this PR @jhidding . What would you usually check as part of a PR? @EmiliaJarochowska if it is about being able to run the model: As is I'm not able to run the model from the provided explanations. |
Hmmm, let's say this PR is purely about merging CA and carbonate production code into |
…ipt module, so they don't interfere
@jhidding and I did some troubleshooting with the namespaces - no more problems from my side with running it |
All the ca (Burgess) stuff runs here. But After I run the Burgess stuff, the bosser schlager 1992 is not working for some reason (I might did some stupid things or have done sth wrong): ERROR: UndefVarError: |
What is the difference between
|
Yeah, I want two things: make it easy to reproduce exact figures in BS92 and B13, but also show users how they may go about changing these things. |
[celebrate] Jarochowska, E.B. (Emilia) reacted to your message:
…________________________________
From: Johannes Hidding ***@***.***>
Sent: Tuesday, October 3, 2023 9:51:23 AM
To: MindTheGap-ERC/CarboKitten ***@***.***>
Cc: Jarochowska, E.B. (Emilia) ***@***.***>; Mention ***@***.***>
Subject: Re: [MindTheGap-ERC/CarboKitten] CA with production (PR #8)
CAUTION: This email originated from outside of Utrecht University. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Merged #8<#8> into main.
—
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AELMSVE6BGIJNKE3EP5RFG3X5PNZXAVCNFSM6AAAAAA5AD6SCSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGUZTMMBRGU3DMMY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Burgess2013 model with only CA and production