Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity config file is reset on every restart #247

Closed
MelvinSnijders opened this issue Dec 16, 2021 · 1 comment · Fixed by #248
Closed

Velocity config file is reset on every restart #247

MelvinSnijders opened this issue Dec 16, 2021 · 1 comment · Fixed by #248

Comments

@MelvinSnijders
Copy link
Contributor

Describe the bug
Every time you restart the velocity server, the config file gets reset and formatted wrong

Screenshots

Desktop (please complete the following information):

  • Plugin Version: 6.6
  • Server Version: Velocity 3.1.1
  • Web client used: client.openaudiomc.net (default)

Additional context
Server is turned off when editing the config.

@MelvinSnijders MelvinSnijders changed the title Velocity config file is reset every restart Velocity config file is reset on every restart Dec 16, 2021
@Mindgamesnl
Copy link
Owner

Hmn, interesting.
It seems to be writing the data.yml contents into the config, somehow. Fields like public/private, version, cc-locale etc aren’t supposed to end up in the config at all. The formatting makes sense, this is technically valid yaml and some libraries (like the one bundled with velocity) write whacky files like this, by default, for somereason.

You can take a peek in the VelocityConfiguration class which implements the configuration properties for that platform and open a pullrequest, it should be fairly straight froward. If you’re unable to, then please let me know so I can take a peek this weekend (probably sunday afternoon~ish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants