Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Folder Images,Audio,Video,Documents are not displaying. One suggestion to add limit file size option property for gallery. #20

Closed
GrishmaPromact opened this issue Dec 11, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@GrishmaPromact
Copy link

GrishmaPromact commented Dec 11, 2020

I download one video, audio, image so it's in my downloads folder. When I am opening galley using your library I can't able to find download folder image, audio, video and document.

I hope it will be resolved as I'm using your library and facing this issue.

One suggestion to add limit file size option property for gallery.

Thanks.

@GrishmaPromact GrishmaPromact changed the title All Folder Images.Audio,Video,Document not displaying. All Folder Images,Audio,Video,Document not displaying. Dec 11, 2020
@GrishmaPromact GrishmaPromact changed the title All Folder Images,Audio,Video,Document not displaying. All Folder Images,Audio,Video,Document not displaying. One suggestion to add limit file size option property for galley. Dec 11, 2020
@GrishmaPromact GrishmaPromact changed the title All Folder Images,Audio,Video,Document not displaying. One suggestion to add limit file size option property for galley. All Folder Images,Audio,Video,Documents are not displaying. One suggestion to add limit file size option property for galley. Dec 11, 2020
@GrishmaPromact GrishmaPromact changed the title All Folder Images,Audio,Video,Documents are not displaying. One suggestion to add limit file size option property for galley. All Folder Images,Audio,Video,Documents are not displaying. One suggestion to add limit file size option property for gallery. Dec 11, 2020
@akashmi akashmi added the enhancement New feature or request label Dec 11, 2020
@akashmi
Copy link
Member

akashmi commented Dec 11, 2020

@GrishmaPromact good suggestions are always welcome.
we will include it in new version.

@GrishmaPromact
Copy link
Author

@akashmi Thanks. :) 👍

@malikmotani
Copy link
Contributor

Hello @GrishmaPromact ,
Thanks for reporting the issue, our team is looking into it. It would be great for us if you can share the below things to understand the cause properly.

  1. Library version
  2. Code snippet
  3. Logs if applicable
  4. Device specification like (Manufacturer, OS version, etc)
  5. Screenshot/video with steps to reproduce the issue

@GrishmaPromact
Copy link
Author

GrishmaPromact commented Dec 17, 2020

Sure. @malikmotani

  1. Library version : 0.1.5
  2. Code snippet : For video opening
    binding.btnVideo.setOnClickListener {
            if (selectedMediaAdapter?.itemCount!! == 4) {
                requireActivity().toast("You have already selected 4 media!!")
            } else {

                var countOfMedia = 0
                countOfMedia = if (selectedMediaAdapter?.itemCount!! == 0)
                    4
                else
                    4 - selectedMediaAdapter?.itemCount!!

                val intent = Lassi(requireActivity())
                        .with(LassiOption.GALLERY)
                        .setMaxCount(countOfMedia)
                        .setGridSize(3)
                        .setMinTime(0)
                        .setMaxTime(30)
                        .setCompressionRation(20)
                        .setMediaType(MediaType.VIDEO)
                        .setStatusBarColor(R.color.colorPrimaryDark)
                        .setToolbarColor(R.color.colorPrimary)
                        .setToolbarResourceColor(android.R.color.white)
                        .setProgressBarColor(R.color.colorAccent)
                        .setPlaceHolder(R.drawable.ic_video_placeholder)
                        .setErrorDrawable(R.drawable.ic_video_placeholder)
                        .setSupportedFileTypes("mp4","mov")
                        .build()
                startActivityForResult(intent, MEDIA_REQUEST_CODE)
            }
        }
    I have put 30 seconds for video but it's not displaying form downloads folder.
    
    3. Logs not displaying 
    
    4. Device specification : 
{
  "deviceInfo": {
    "device_android_id": "6487d5b71bb6c671",
    "device_api_level": "29",
    "device_board": "exynos9611",
    "device_boot_loader": "M315FXXU2ATJ9",
    "device_brand": "samsung",
    "device_build_id": "QP1A.190711.020",
    "device_build_time": "1603539510000",
    "device_fingerprint": "samsung/m31nnxx/m31:10/QP1A.190711.020/M315FXXU2ATJ9:user/release-keys",
    "device_hardware": "exynos9611",
    "device_host": "SWDH4603",
    "device_manufacturer_of_device": "samsung",
    "device_model": "SM-M315F",
    "device_screen_density": "420 dpi",
    "device_screen_resolution": "2131 * 1080 Pixels",
    "device_serial_no": "unknown",
    "device_type": "Android",
    "device_user": "dpi",
    "request_from": "Mobile"
  }
}

it's not device specific issue though. I have tested on another device too, but it's not displaying.

  1. Attaching video - I am clicking on video and opening your library but video folder is not displaying.

ezgif-5-12406dc0ecc1

@malikmotani
Copy link
Contributor

@GrishmaPromact
The download folder video length may be more than 30 seconds, you have added
.setMinTime(0) .setMaxTime(30)

So the library won't show the videos which have longer lengths than 30seconds. Please try to remove these attributes since its optional or increase the max time and check again.

@GrishmaPromact
Copy link
Author

@malikmotani video is 30 seconds only. I have verified by my end.

MicrosoftTeams-image (4)
Attached SS for your reference.

@malikmotani
Copy link
Contributor

@GrishmaPromact
Thanks for the snap, I tried to reproduce your case by downloading the same video sample. And I have found that the video length is 30528 milliseconds (which != 30 seconds) please try with the video which has the length of 30000 milliseconds

@GrishmaPromact
Copy link
Author

@malikmotani But in seconds it is displaying 30 seconds. That means video is 30 seconds. So think you need to include that video.

@malikmotani
Copy link
Contributor

@GrishmaPromact
We have added the file size limit feature, please update library version 0.1.6 to use this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants