Added CORS policy for tts get request #634
Conversation
server/backend/Startup.cs
Outdated
| @@ -26,6 +26,10 @@ public void ConfigureServices(IServiceCollection services) | |||
| builder.AllowAnyOrigin().AllowAnyMethod().AllowAnyHeader().WithExposedHeaders( | |||
| "Grpc-Status", "Grpc-Message", "Grpc-Encoding", "Grpc-Accept-Encoding"); | |||
| })); | |||
| services.AddCors(o => o.AddPolicy("AllowAudioFileGet", builder => | |||
There was a problem hiding this comment.
merge with the previous call to services.AddCors(?
i.e.
services.AddCors(o => {
o.AddPolicy...
o.AddPolicy...
There was a problem hiding this comment.
Or, I think you can just reuse the AllowAll policy (it's more lenient than AllowAudioFileGet)
No. I think we should check |
|
Nice work! Free free to merge. |
|
tip: We have mergify bot configured to automerge a PR when tests pass. You can write the commit message in a subheading called |
What's the purpose of adding the commit message subheading? |
The default commit message generated by github is not always what you'd expect. Since we ask mergify to merge automatically, we want to tell mergify exactly what commit message to use, rather than using the github default. According to mergify docs: "you can override the default commit message... add a section in the pull request body that starts with Commit Message." |
ztl8702
changed the title
Issue: #633