Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Shingle variation #1873

Closed
Raycoms opened this issue Dec 18, 2017 · 9 comments · Fixed by #1902
Closed

Implement new Shingle variation #1873

Raycoms opened this issue Dec 18, 2017 · 9 comments · Fixed by #1902
Assignees

Comments

@Raycoms
Copy link
Contributor

Raycoms commented Dec 18, 2017

Until now we have only the oak shingle variation.
What we need:

Implement all shingle variations with the models and textures we have.

What needs to be done:

  • Create block and blockStates as well as recipe for those blocks.
@bob0bob bob0bob self-assigned this Dec 18, 2017
@Moobien
Copy link

Moobien commented Dec 21, 2017

Shingle recipe could be as simple as

X X os
X os ow
os ow ow

Os oak slab. Ow oak wood

@bob0bob
Copy link
Contributor

bob0bob commented Dec 21, 2017

X - clay?

If I read this right.
x (clay) 3
os (oak slab) 3
ow (oak wood) 3

This would be all 9 blocks filled? This is the plan?

This is for just a Shingle? or 3 shingle pieces?

I don't get it. I was wondering about this. From the code, it references clay shingle?

from the models, everything is a clay roof. Is there any other plans to make a wood shingle instead of clay. For different looks?

@Moobien
Copy link

Moobien commented Dec 21, 2017

X for nothing lol. No clay. As for how much it makes i would suggest at least 2

@Moobien
Copy link

Moobien commented Dec 21, 2017

You would replace the wood and slabs with other materials for other types of shingle

@bob0bob
Copy link
Contributor

bob0bob commented Dec 21, 2017

Ok. That seems weird, the roof tile is clay. they have all the same look. Only difference is the support beam. Which will not been seen unless you don't have a flat roof. (drop down ceiling). Otherwise it will be covered up. Or did I miss something.

@Moobien
Copy link

Moobien commented Dec 21, 2017

Depends on the rooftile. @rqycoms specifically mentioned oak wood so i suggested a recipe based on that.

@Raycoms
Copy link
Contributor Author

Raycoms commented Dec 21, 2017

since there will be different variations our idea of the recipe was the following:

B
BB
SPS

S= stick
P = plank
B = Brick Item

@Moobien
Copy link

Moobien commented Dec 21, 2017

That could work dude

@bob0bob
Copy link
Contributor

bob0bob commented Dec 21, 2017

Looking at these shingle models. I wanted to ask. there appears to be no point in having any other wood types. All of them appear to be clay shingles. The only thing that changes is the support beams. When you have a finished house oak,spruce, dark wood will all look the same unless you have see the bottom of the block.

Of course every item has clay in it. my thoughts is having only one clay shingle and the shingles change to wood shingles and have them different wood types and looks. I don't get only thing that changes is something that is not noticeable at the end. it seems like work that will never be worth the effort.

@Raycoms Raycoms mentioned this issue Dec 23, 2017
@ghost ghost assigned Raycoms Dec 23, 2017
@ghost ghost added the In Progress label Dec 23, 2017
@ghost ghost removed the In Progress label Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants