Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Minecraft #10

Open
ThexXTURBOXx opened this issue Jul 30, 2023 · 5 comments
Open

Legacy Minecraft #10

ThexXTURBOXx opened this issue Jul 30, 2023 · 5 comments

Comments

@ThexXTURBOXx
Copy link

ThexXTURBOXx commented Jul 30, 2023

As far as I have read, some 1.4.7 mods are also affected by the BleedingPipe vulnerability.
So, I have forked the project and modified some files such that the mod works with MC versions 1.3.2, 1.4.7, 1.5.2 and 1.6.4.
Versions in between should also work, but I have not tested them! Also, older or newer versions could also work, but again: Untested!
Downloads available here

Just wanted to let you know :)

@Semisol
Copy link
Collaborator

Semisol commented Jul 30, 2023

As far as I have read, some 1.4.7 mods are also affected by the BleedingPipe vulnerability. So, I have forked the project and modified some files such that the mod works with MC versions 1.3.2, 1.4.7, and 1.5.2. Versions in between should also work, but I have not tested them! Also, older or newer versions could also work, but again: Untested!

Just wanted to let you know :)

Nice. We'll look into having something for those versions if we can.
I'd also recommend keeping the tests in common/, since sometimes updates might break shit :)

@xyzeva
Copy link
Member

xyzeva commented Jul 30, 2023

Hey - Could you PR your changes?

@Semisol
Copy link
Collaborator

Semisol commented Jul 30, 2023

Actually, I'm not sure if we can backport it to older versions -- Java 7 or lower don't support the filtering interface we use AFAIK.

@ThexXTURBOXx
Copy link
Author

Nice. We'll look into having something for those versions if we can.

Very nice to hear! So, my fork can at least act as a temporary solution :)

I'd also recommend keeping the tests in common/, since sometimes updates might break shit :)

JUnit 5 and Java 7 don't like each other apparently. So, I just deleted them for the time being. Maybe, I can add them back later

Hey - Could you PR your changes?

Not a good idea: My fork almost certainly does not work on newer Minecraft versions (which is what most people will prefer)

Actually, I'm not sure if we can backport it to older versions -- Java 7 or lower don't support the filtering interface we use AFAIK.

Exactly :)

@ThexXTURBOXx
Copy link
Author

1.6.4 is also now supported on my fork btw! And builds are available through CD :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants