Skip to content
This repository has been archived by the owner on May 26, 2018. It is now read-only.

FML Network disconnect events are not called #381

Closed
jeffreykog opened this issue Feb 23, 2014 · 2 comments
Closed

FML Network disconnect events are not called #381

jeffreykog opened this issue Feb 23, 2014 · 2 comments

Comments

@jeffreykog
Copy link
Contributor

Both FMLNetworkEvent.ClientDisconnectionFromServerEvent and FMLNetworkEvent.ServerDisconnectionFromClientEvent do not seem to be called.

I don't have time to test or try to find a fix for it, but i think it could be fixed by moving the following piece of code: https://github.com/MinecraftForge/FML/blob/master/src/main/java/cpw/mods/fml/common/network/handshake/NetworkDispatcher.java#L363-L370 down to the close method under it.

@jeffreykog
Copy link
Contributor Author

Yes i can confirm that that does fix it. I tested it by adding a handler to the vanilla pipeline myself and putting the code in the close method. Expect an PR somewhere in the next hour

@cpw
Copy link
Contributor

cpw commented Feb 23, 2014

Please do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants