Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target layer configuration for third-party jars #3

Closed
Su5eD opened this issue Oct 29, 2022 · 1 comment
Closed

Target layer configuration for third-party jars #3

Su5eD opened this issue Oct 29, 2022 · 1 comment

Comments

@Su5eD
Copy link

Su5eD commented Oct 29, 2022

Currently, there is no way of changing the target layer of third-party non-mc jars. Instead, they are all put on the GAME layer, making it impossible for language providers to access them.

I'm aware that this issue is known as it was previously mentioned in MinecraftForge, although I'd like to discuss possible solutions for it.

  1. How do we want to define the target jar layer?
    Should the target layer be defined in jarJar metadata, or should we use the manifest FMLModType attribute?
  2. How do we want to handle layer selection? Should we account for layer conflicts?
    SizableShrimp's suggestion was to poll all selection candidates and put the selected jar on the lowest requested layer. However, this might become an issue if a mod wants to apply transformations to that library, but it ends up on the PLUGIN layer, making it non-transformable.
@marchermans
Copy link
Contributor

This was discussed before.
JarJar is primarily ment for mods, not for ModLauncher plugins.

It has been discussed internally and any change to this has been rejected.
I am sorry as such we won't be implementing this.

@marchermans marchermans closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants