Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #8

Closed
wants to merge 2 commits into from
Closed

Minor fixes #8

wants to merge 2 commits into from

Conversation

malte0811
Copy link

ece59ac: This is "nice to have" in general, and also fixes a strange SIGSEGV I have been running into when launching MC in dev.

4df082e: Before only put/remove calls were synchronized, which prevented two simultaneous modifications, but not a modification during a read. If there are performance concerns about using a "general purpose" lock/mutex here I can replace it with a ReadWriteLock.

@malte0811
Copy link
Author

Clearly this repo and the idiots running it are not interested in external contributions, to the degree where even asking for additional justification is too much work.

@malte0811 malte0811 closed this Aug 21, 2021
@LexManos
Copy link
Contributor

Whelp, called the rage quit. Anyways, as stated in the other issue. The reason this one was left alone is because it contained no justification. No discussion with anyone else. No reproduction steps. And until just recently was unverified to actually exist {none of the team had encountered it even while trying to reproduce}. Luckily one of our other community members was able to independently run into this issue on their own and actually sat down to understand and explain the issue.

Just for the record, malte has a history of these 'Just do what I say' without explanation PRs, and a history of throwing a fit if we try and verify or get any more information out of him. So my personal approach is to ignore until a 3rd party can verify/deal with it. (Which is why this PR has no response, even tho I've seen it)

You're more then welcome to submit issues/fixes if you're willing to discuss and back them up.

@McModLauncher McModLauncher locked as too heated and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants