Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ece59ac: This is "nice to have" in general, and also fixes a strange SIGSEGV I have been running into when launching MC in dev.
4df082e: Before only
put
/remove
calls were synchronized, which prevented two simultaneous modifications, but not a modification during a read. If there are performance concerns about using a "general purpose" lock/mutex here I can replace it with aReadWriteLock
.