Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for negative caching #55

Open
ppanero opened this issue Mar 1, 2017 · 10 comments
Open

Add support for negative caching #55

ppanero opened this issue Mar 1, 2017 · 10 comments

Comments

@ppanero
Copy link

ppanero commented Mar 1, 2017

Add support for negative caching. I offer myself to implement this feature, but I would like to have a chat in order to discuss possible implementations (Gitter?)

@Flowdalic
Copy link
Collaborator

MiniDNS should already cache negative responses. Or am I missing someting?

The main discussion venue for MiniDNS is the #smack IRC channel at Freenode.

@ppanero
Copy link
Author

ppanero commented Mar 1, 2017

In this case:

    val client = new DNSClient(new LRUCache(3));
    val resolver = new ResolverApi(client)
    //client.getCache.asInstanceOf[LRUCache].getMissCount
    val result = resolver.resolve("www.asdasd.co.uk", classOf[A])
    val result2 = resolver.resolve("www.asdasd.co.uk", classOf[A])

Shouldn't the second one have been cached as a negative entry? Same should happen for an IP that give NX_DOMAIN in every DNS server. Right?

@Flowdalic
Copy link
Collaborator

Sorry, I was wrong. MiniDNS does not yet cache negative results.

@ppanero
Copy link
Author

ppanero commented Mar 6, 2017

@Flowdalic Is anyone working on this? If not, do you want me to do it?

@Flowdalic
Copy link
Collaborator

@Flowdalic Is anyone working on this? If not, do you want me to do it?

I'm not aware of anyone working on it. And I certainly will not you stop from doing so :) Is this regarding of GSOC or so?

@ppanero
Copy link
Author

ppanero commented Mar 6, 2017

@Flowdalic Nope. We would like to use it for some project at CERN. I will try to do it then. Any special thing to have into account?

@Flowdalic
Copy link
Collaborator

Flowdalic commented Mar 6, 2017

@Flowdalic Nope. We would like to use it for some project at CERN. I will try to do it then. Any special thing to have into account?

When I worked on MiniDNS's cache I found that correctly caching DNS information is harder that I expected. It's not just as simple as a key/value key, although one may think so. It gets even more complicated if you want to use the information found in DNS replies to synthesize answers for other questions. I'm happy to support you whenever I can, but ideally not via this github issue. So feel encouraged to start an conversation with me in the Smack's IRC channel (#smack, freenode).

@Flowdalic
Copy link
Collaborator

From #85

This mostly includes caching of NX_DOMAIN and optionally, if DNSSEC is used, NSEC and NSEC3 proofs of non-existence. Probably not trivial to implement.

@ppanero
Copy link
Author

ppanero commented Nov 9, 2018

Hello @Flowdalic , I do not longer work on the project that was using this library. I can try contact them. Nonetheless, from my side, if not needed for you, it can be closed.
Cheers!

@ppanero ppanero closed this as completed Nov 14, 2018
@Flowdalic
Copy link
Collaborator

No need to close this issue until negative caching is implemented.

@Flowdalic Flowdalic reopened this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants