Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifier state broken after TTY switch #999

Closed
wmww opened this issue Sep 16, 2019 · 0 comments · Fixed by #1035
Closed

Modifier state broken after TTY switch #999

wmww opened this issue Sep 16, 2019 · 0 comments · Fixed by #1035
Assignees
@AlanGriffiths
Labels
bug

Comments

@wmww
Copy link
Contributor

wmww commented Sep 16, 2019

When Mir is running on a TTY and a user switches to another TTY with Ctrl+Alt+#, the Ctrl and Alt modifiers are sent to the client with current keyboard focus. When switching back to the Mir TTY, they are not removed (even after pressing and releasing the modifiers). This generally results in the appearance that input is broken. I have a recollection of this getting reported before, but I can't find it.
@RAOF RAOF added the bug label Sep 17, 2019
@AlanGriffiths AlanGriffiths self-assigned this Oct 8, 2019
@AlanGriffiths AlanGriffiths mentioned this issue Oct 8, 2019
Merged
@bors bors bot closed this as completed in 0f67cb0 Oct 8, 2019
@bors bors bot closed this as completed in #1035 Oct 8, 2019
@wmww wmww mentioned this issue Aug 16, 2021
Merged
bors bot added a commit that referenced this issue Aug 18, 2021
@bors @wmww
Merge #2146
3b6683c 
2146: Add resync keyboard event r=AlanGriffiths a=wmww

This creates a new `MirResyncKeyboardEvent` and a new event dispatcher that fires it when the server starts. This replaces the resync system that was added in  #1035. If this works (which it does on my machine), #999 should stay fixed.

The motivation for this is that in the future I will implement alternative Wayland keyboard interfaces that will need the same resync behavior, but will not be accessible by the seat in the same way. An event ensures there is one unified way to pass changes to the active keyboard-like thing.

Co-authored-by: William Wold <wm@wmww.sh>
bors bot added a commit that referenced this issue Aug 18, 2021
@bors @wmww @AlanGriffiths
Merge #2146
d31dd29 
2146: Add resync keyboard event r=AlanGriffiths a=wmww

This creates a new `MirResyncKeyboardEvent` and a new event dispatcher that fires it when the server starts. This replaces the resync system that was added in  #1035. If this works (which it does on my machine), #999 should stay fixed.

The motivation for this is that in the future I will implement alternative Wayland keyboard interfaces that will need the same resync behavior, but will not be accessible by the seat in the same way. An event ensures there is one unified way to pass changes to the active keyboard-like thing.

Co-authored-by: William Wold <wm@wmww.sh>
Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlanGriffiths AlanGriffiths

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resync keyboard state after server is paused canonical/mir
3 participants
@RAOF @AlanGriffiths @wmww