New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Fedora 27 CI target #119
Conversation
Because I don't have the Linode key I'm not actually sure if this will work in the Linode; it does in LXD, though! |
spread/build/fedora/task.yaml
Outdated
cd $(mktemp --directory) | ||
cmake $SPREAD_PATH -DCMAKE_BUILD_TYPE=Debug -DMIR_USE_LD_GOLD=ON -G Ninja | ||
ninja | ||
ninja ptest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having discovered cmake -H<source_dir> -B<build_dir>
, think we could use that along with cmake --build<build_dir>
?
Various things which *aren't* /dev/dri/card0 are sub-devices of card0, and get matched by our filter. These things don't have a devnode, and so device.devnode() is NULL. Skip such udev nodes when trying to open /dev/dri/card[0-9]. Fixes several crashes in the test-suites on Fedora 27
mir_integration.cpp uses wayland-client symbols explicitly, and Fedora's linker doesn't resolve from the transitive dependency (mirserver links wayland-client).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine in principle, but while we only have one CI node I'm not sure it is worth the cost. (AIUI we should get more nodes "real soon", let's see what happens before "bors r+".)
"we have 4 linodes now" - thanks @Saviq bors r+ |
Build succeeded |
No description provided.