Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Make LTTNG fork()-safe #1496

Merged
merged 2 commits into from Jun 1, 2020
Merged

Tests: Make LTTNG fork()-safe #1496

merged 2 commits into from Jun 1, 2020

Conversation

RAOF
Copy link
Contributor

@RAOF RAOF commented Jun 1, 2020

LTTNG documentation makes it clear that using fork() without exec() in applications linked to liblttng-ust is unsafe unless you preload liblttng-ust-fork.so. Do so! (Fixes #1405)

This fixes a test failure where running ThreadedDispatcherSignalTest immediately after the Logind tests would fail.

RAOF added 2 commits June 1, 2020 17:57
[LTTNG documentation](https://lttng.org/man/3/lttng-ust/v2.12/#doc-_using_lttng_ust_with_daemons) makes it clear that
using `fork()` without `exec()` in applications linked to `liblttng-ust` is unsafe unless you preload
`liblttng-ust-fork.so`. Do so!
@RAOF
Copy link
Contributor Author

RAOF commented Jun 1, 2020

(Stacked on #1495, because I need that to fix the build)

@AlanGriffiths
Copy link
Contributor

/me sees a possible straw: I wonder if this fixes #1405...

Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 1, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Fedora rawhide tests have a tendency to hang for no obvious reason
2 participants