KMS platform - fallback if crtc mode invalid #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to using the mode named "preferred" as current mode
gerboland
changed the title
|
Hmm no, only partial fix. Unity8/QtMir isn't crashing on startup any more, but is still reading incorrect display mode data... Nested mir servers are reading the right thing. Difference concerns me |
|
This is working ok, the problem is in QtMir. |
AlanGriffiths
approved these changes
Mar 14, 2018
bors bot
added a commit
that referenced
this pull request
Mar 14, 2018
165: RFC: KMS platform - fallback if crtc mode invalid r=AlanGriffiths a=gerboland RFC - not ideal but I see no better way. If the current mode advertised by the crtc does not exist in the list of modes, fall back to using the mode named "preferred" as current mode. Fixes nested server run on VMWare: https://bugs.launchpad.net/mir/+bug/1661295
gerboland
changed the title
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2018
165: KMS platform - fallback if crtc mode invalid r=AlanGriffiths a=gerboland If the current mode advertised by the crtc does not exist in the list of modes, fall back to using the mode named "preferred" as current mode. Some VMs specify this. Fixes nested server run on VMWare: https://bugs.launchpad.net/mir/+bug/1661295
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current mode advertised by the crtc does not exist in the list of modes, fall back to using the mode named "preferred" as current mode. Some VMs specify this.
Fixes nested server run on VMWare: https://bugs.launchpad.net/mir/+bug/1661295