Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some outdated docs #1774

Merged
merged 2 commits into from Oct 21, 2020
Merged

Fix some outdated docs #1774

merged 2 commits into from Oct 21, 2020

Conversation

AlanGriffiths
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails when I run with:

$ miral-app -terminal 'glmark2-es2-wayland --fullscreen'
# ...
[2020-10-21 12:39:56.191376] < -warning- > miral: Failed to execute client ("glmark2-es2-wayland --fullscreen") error: No such file or directory

It seems to not deal with arguments (-kiosk is fine). Not sure if you want to tackle this in this PR, though?

@AlanGriffiths
Copy link
Contributor Author

It seems to not deal with arguments (-kiosk is fine).

That is true.

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 21, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit d2089d9 into master Oct 21, 2020
@bors bors bot deleted the update-docs branch October 21, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants