Add wlcs tests

[RAOF]

This integrates wlcs with the Mir test-suite, gated on MIR_RUN_ACCEPTANCE_TESTS.

It then fixes the bugs exposed!

[AlanGriffiths]

When I build and run locally I see (once I persuaded make to even run the wlcs test):

The following tests FAILED:
5 - mir_wlcs_tests.BadBufferTest.* (Failed)
6 - mir_wlcs_tests.ClientSurfaceEventsTest.* (Failed)

Both tests segfault!

Not sure what happens in CI - there's no output from the test run.

[AlanGriffiths]

It is always wrong when "(this=0x0"

(gdb) bt
#0 0x00007ffff7b61484 in std::unique_ptr<wlcs::ShmBuffer::Impl, std::default_deletewlcs::ShmBuffer::Impl >::get (this=0x0) at /usr/include/c++/6/bits/unique_ptr.h:308
#1 0x00007ffff7b5ef3e in std::unique_ptr<wlcs::ShmBuffer::Impl, std::default_deletewlcs::ShmBuffer::Impl >::operator-> (this=0x0) at /usr/include/c++/6/bits/unique_ptr.h:302
#2 0x00007ffff7b5be94 in wlcs::ShmBuffer::add_release_listener(std::function<bool ()> const&) (this=0x0,
on_release=...)
at /home/alan/MirServer/mir/tests/acceptance-tests/wayland/wlcs/src/in_process_server.cpp:454
#3 0x00007ffff7b5ca93 in wlcs::Client::Impl::create_visible_surface (this=0x555555ad4d30, client=...,
width=200, height=200)
at /home/alan/MirServer/mir/tests/acceptance-tests/wayland/wlcs/src/in_process_server.cpp:211
#4 0x00007ffff7b5bc00 in wlcs::Client::create_visible_surface (this=0x7fffffffd6b8, width=200, height=200)
at /home/alan/MirServer/mir/tests/acceptance-tests/wayland/wlcs/src/in_process_server.cpp:303
#5 0x00007ffff7b64e15 in BadBufferTest_test_truncated_shm_file_Test::TestBody (this=0x555555acaeb0)
at /home/alan/MirServer/mir/tests/acceptance-tests/wayland/wlcs/tests/test_bad_buffer.cpp:79
#6 0x00007ffff7b9543b in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (
object=0x555555acaeb0, method=&virtual testing::Test::TestBody(),

[AlanGriffiths]

    // It's safe to free the buffer after the release event has been received.
    buffer->add_release_listener([buffer = std::move(buffer)]() { return false; });

But it is not safe to use buffer->add_release_listener when it isn't sequence-before the std::move()

[AlanGriffiths]

OK, I've proposed a fix against wlcs. But that doesn't get everything working.

1. the wlcs tests seem to only run if -DENABLE_MEMCHECK_OPTION=on (not obvious to me why)
2. with that option on I get:

$ ctest -V -R .wlcs.
The following tests passed:
mir_wlcs_tests_no_memcheck

50% tests passed, 1 tests failed out of 2

Total Test time (real) = 15.64 sec

The following tests FAILED:
13 - mir_wlcs_tests (Failed)
Errors while running CTest

[AlanGriffiths]

I've pushed the fix for mir_wlcs_tests to wlcs - was just bad setup in mir_integration.cpp

Still need to work out what's happening with getting the tests to actually run

[AlanGriffiths]

In any case, these tests are leaking FDs and fail with ENABLE_MEMCHECK_OPTION=on

[AlanGriffiths]

This is what doesn't work for me:

git clone https://github.com/MirServer/mir
cd mir
git checkout add-wlcs-tests
git submodule update --init --recursive
mkdir build
cd build/
cmake ..
ctest --show-only | grep wlcs
(nothing)

However:

cmake -DENABLE_MEMCHECK_OPTION=on ..
ctest --show-only | grep wlcs
Test #13: mir_wlcs_tests
...

[AlanGriffiths]

anyway, I think we can leave that as an exercise for later.

bors r+

[bors]

Build succeeded

• continuous-integration/travis-ci/push