Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsurface ordering #2491

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Subsurface ordering #2491

wants to merge 2 commits into from

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Jun 23, 2022

Attempt at implementing subsurface re-ordering. This should work but I have no way to test. The WLCS tests that failed before still fail, but I don't trust that they're correct. I'm not going to put more work into getting this merged at this time, but if anyone wants to push this feature through this might be a good starting point.

Possibly fixes #2487.

@fredldotme
Copy link

fredldotme commented Jul 1, 2022

I will gladly take on the challenge. Depending on our plans in Ubuntu Touch this might mean either backporting & refining on top of Mir 1.8 or taking 2.x as is and reporting back

This is more or less a requirement for supporting proper stacking of surfaces in multi-window mode in Waydroid, the Android compatibility solution for GNU/Linux systems.

@Saviq
Copy link
Collaborator

Saviq commented Sep 21, 2022

Hi @fredldotme, got any updates on this?

@wmww
Copy link
Contributor Author

wmww commented Sep 22, 2022

Fixes #345.

@fredldotme
Copy link

Just came around to notify I intend to take a look as soon as my lunar dev environment on my M1 is properly functioning. The idea is to test Waydroid on that configuration soon since I wouldn't have to backport anything really.

@AlanGriffiths
Copy link
Contributor

This has been around 9 months, but still "Some checks haven’t completed yet"!

I wonder why?

@Saviq
Copy link
Collaborator

Saviq commented Jun 22, 2023

I wonder why?

Because the set of required checks has changed since. I've rebased so it gets refreshed.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2491 (b714cac) into main (8186492) will increase coverage by 0.00%.
The diff coverage is 91.42%.

@@           Coverage Diff           @@
##             main    #2491   +/-   ##
=======================================
  Coverage   78.36%   78.37%           
=======================================
  Files        1054     1054           
  Lines       72041    72068   +27     
=======================================
+ Hits        56457    56481   +24     
- Misses      15584    15587    +3     
Impacted Files Coverage Δ
src/server/frontend_wayland/wl_surface.h 100.00% <ø> (ø)
src/server/frontend_wayland/wl_surface.cpp 82.00% <88.88%> (+0.35%) ⬆️
src/server/frontend_wayland/wl_subcompositor.cpp 94.62% <100.00%> (+0.37%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow WlSubsurfaces to be placed explicitly relative to hierarchy
4 participants