Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call global_mock->XInitThreads() if global mock exists #2569

Merged
merged 1 commit into from Aug 24, 2022
Merged

Only call global_mock->XInitThreads() if global mock exists #2569

merged 1 commit into from Aug 24, 2022

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Aug 22, 2022

Fixes #2568

AlanGriffiths
AlanGriffiths approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this is necessary, but it should be harmless

bors merge

bors bot added a commit that referenced this pull request Aug 23, 2022
@bors @wmww
Merge #2569
c3e4770 
2569: Only call global_mock->XInitThreads() if global mock exists r=AlanGriffiths a=wmww

Fixes #2568

Co-authored-by: Sophie Winter <wm@wmww.sh>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Build failed:

@AlanGriffiths
Copy link
Contributor

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 24, 2022

Build succeeded:

@bors bors bot merged commit dde3dba into main Aug 24, 2022
@bors bors bot deleted the arch-fix-tests branch August 24, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mir_unit_tests crashes in initialization on Arch
2 participants
@wmww @AlanGriffiths