Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Use non-fat LTO #2634

Merged
merged 1 commit into from
Sep 13, 2022
Merged

CMake: Use non-fat LTO #2634

merged 1 commit into from
Sep 13, 2022

Conversation

RAOF
Copy link
Contributor

@RAOF RAOF commented Sep 13, 2022

Fat LTO objects slow down the build. We don't need fat LTO objects, as we don't ship any LTO'd static archives.

@RAOF
CMake: Use non-fat LTO
87aa571 
Fat LTO objects slow down the build. We don't *need* fat LTO objects,
as we don't ship any LTO'd static archives.
wmww
wmww approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

@bors
Copy link
Contributor

bors bot commented Sep 13, 2022

Build succeeded:

@bors bors bot merged commit 0ce4562 into main Sep 13, 2022
@bors bors bot deleted the drop-fat-LTO branch September 13, 2022 19:03
@AlanGriffiths AlanGriffiths mentioned this pull request Sep 14, 2022
Merged
AlanGriffiths added a commit that referenced this pull request Sep 14, 2022
@AlanGriffiths
Revert "Merge #2634"
9e50232 
This reverts commit 0ce4562, reversing
changes made to e8c0e7a.
bors bot added a commit that referenced this pull request Sep 14, 2022
@bors @AlanGriffiths
Merge #2637
cd83d60 
2637: Revert "Merge #2634" r=Saviq a=AlanGriffiths

Merge #2634 broke builds in ppa:mir-team/dev

(Revert pending investigation)

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmww wmww wmww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RAOF @wmww