platform/DRMFormat: Add as_mir_format converter #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGriffiths
approved these changes
Dec 14, 2022
Saviq
force-pushed
the
core-shm-handling
branch
from
0773c6f
to
5bd6ae6
Compare
Saviq
force-pushed
the
format-helpers
branch
from
176d3e8
to
7f80018
Compare
Saviq
force-pushed
the
core-shm-handling
branch
from
5bd6ae6
to
1bf2d75
Compare
Ideally we would migrate to a world where `DRMFormat` is the canonical type for pixel formats; there are more of them, and the descriptor contains more useful information that code using `MirPixelFormat` has had to ad-hoc. Make it possible to start doing this by adding a conversion from `DRMFormat` to `MirPixelFormat`. This is necessarily lossy, as there are a lot of `DRMFormat`s that have no corresponding `MirPixelFormat`, but that implies that *current* code couldn't have properly handled them, so it's OK.
Saviq
force-pushed
the
format-helpers
branch
from
7f80018
to
8514a80
Compare
|
This can now go in. bors r=AlanGriffiths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we would migrate to a world where
DRMFormatis the canonical type for pixel formats; there are more of them, and the descriptor contains more useful information that code usingMirPixelFormathas had to ad-hoc.Make it possible to start doing this by adding a conversion from
DRMFormattoMirPixelFormat. This is necessarily lossy, as there are a lot ofDRMFormats that have no correspondingMirPixelFormat, but that implies that current code couldn't have properly handled them, so it's OK.