Bump XDG shell stable protocol from version 1 to 5 #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGriffiths
approved these changes
Mar 10, 2023
Comment on lines
+101
to
+102
| # Not yet implemented, see https://github.com/MirServer/mir/issues/2861 | ||
| XdgPopupTest.when_parent_surface_is_moved_a_reactive_popup_is_moved |
There was a problem hiding this comment.
There's some overlap between "reactive" popups and "satellites" that we should consider in the window management code.
Comment on lines
476
to
+478
| Destroy the xdg_surface object. An xdg_surface must only be destroyed | ||
| after its role object has been destroyed. | ||
| after its role object has been destroyed, otherwise | ||
| a defunct_role_object error is raised. |
There was a problem hiding this comment.
We've recently been discussing this condition (and we are not raising this error).
Comment on lines
+536
to
+539
| will raise an invalid_size error. When applied, the effective window | ||
| geometry will be the set window geometry clamped to the bounding | ||
| rectangle of the combined geometry of the surface of the xdg_surface and | ||
| the associated subsurfaces. |
There was a problem hiding this comment.
we are not raising this error
Comment on lines
+879
to
+885
| void mf::XdgPositionerStable::set_parent_size(int32_t parent_width, int32_t parent_height) | ||
| { | ||
| (void)parent_width; | ||
| (void)parent_height; | ||
| // TODO | ||
| log_warning("xdg_positioner.set_parent_size not implemented"); | ||
| } |
There was a problem hiding this comment.
We ought to have a plan for cleaning up these "TODO"s
Comment on lines
+887
to
+892
| void mf::XdgPositionerStable::set_parent_configure(uint32_t serial) | ||
| { | ||
| (void)serial; | ||
| // TODO | ||
| log_warning("xdg_positioner.set_parent_configure not implemented"); | ||
| } |
There was a problem hiding this comment.
We ought to have a plan for cleaning up these "TODO"s
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2778. Not sure if more things need to be implemented before we ship it. Definitely needs manual testing and WLCS coverage.