Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miral] refactor YamlFileDisplayConfig::apply_to() #2814

Merged
merged 2 commits into from Jan 27, 2023
Merged

[miral] refactor YamlFileDisplayConfig::apply_to() #2814

merged 2 commits into from Jan 27, 2023

Conversation

AlanGriffiths
Copy link
Contributor

This method contained a lambda over 100 lines long with multiple responsibilities.

This splits the responsibilities between an 11 line lambda and two new methods each with a single responsibility.

Note to reviewers: This is a pure refactoring with no functional changes

Saviq
Saviq approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 27, 2023

Build succeeded:

@bors bors bot merged commit 7453a53 into main Jan 27, 2023
@bors bors bot deleted the Refactor_YamlFileDisplayConfig_apply_to branch January 27, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlanGriffiths @Saviq