Add a .display-layout configuration file #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGriffiths
added a commit
to canonical/ubuntu-frame
that referenced
this pull request
Feb 13, 2023
AlanGriffiths
added a commit
to canonical/ubuntu-frame
that referenced
this pull request
Feb 13, 2023
wmww
suggested changes
Feb 15, 2023
src/miral/static_display_config.cpp
Outdated
| std::lock_guard lock{mutex}; | ||
| if (!config_path_) return; | ||
|
|
||
| if (std::ifstream layout_file{config_path_.value() + "/" + basename + "-layout"}) |
There was a problem hiding this comment.
The "-layout" string literal only appears twice, but still seems like it would be a better idea to not repeat it. You could have a const global, a layout_override_for_basename(basename) standalone helper or something else.
bors bot
pushed a commit
to canonical/ubuntu-frame
that referenced
this pull request
Feb 17, 2023
This allows the active display layout to switched without restarting Frame requires canonical/mir#2832 to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a .display configuration fle is used add an additional .display-layout configuration file.
Creating or updating this file will update the active display layout.