New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API for adding custom attributes to outputs #2853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given_custom_attributes_when_they_are_not_added_they_are_not_applied given_custom_attributes_when_they_are_added_they_are_applied given_no_custom_attributes_when_they_are_added_they_are_applied given_no_custom_attributes_when_they_are_added_existing_attributes_are_cleared
For a usage example see: |
wmww
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+
bors bot
pushed a commit
to canonical/ubuntu-frame
that referenced
this pull request
Mar 8, 2023
Uses canonical/mir#2853 to associate surface titles with outputs and move those apps to those outputs WIP as: 1. it won't build on edge without the Mir PR landing; and, 2. there's more to be done to support other ways to map apps to outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by Frame needing a way to assign apps to outputs