Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API for adding custom attributes to outputs #2853

Merged
merged 8 commits into from Mar 1, 2023
Merged

Conversation

AlanGriffiths
Copy link
Contributor

This is motivated by Frame needing a way to assign apps to outputs

given_custom_attributes_when_they_are_not_added_they_are_not_applied
given_custom_attributes_when_they_are_added_they_are_applied
given_no_custom_attributes_when_they_are_added_they_are_applied
given_no_custom_attributes_when_they_are_added_existing_attributes_are_cleared
@AlanGriffiths
Copy link
Contributor Author

For a usage example see:

canonical/ubuntu-frame#129

@AlanGriffiths AlanGriffiths requested a review from Saviq March 1, 2023 12:25
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

@bors bors bot merged commit 7736c95 into main Mar 1, 2023
@bors bors bot deleted the client-placement branch March 1, 2023 18:00
bors bot pushed a commit to canonical/ubuntu-frame that referenced this pull request Mar 8, 2023
Uses canonical/mir#2853 to associate surface titles with outputs and move those apps to those outputs

WIP as:

1. it won't build on edge without the Mir PR landing; and,
2. there's more to be done to support other ways to map apps to outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants