New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect cyclic parent-child relationships #2862
Conversation
src/miral/basic_window_manager.cpp
Outdated
{ | ||
if (window_info.window() == ancestor) | ||
{ | ||
BOOST_THROW_EXCEPTION(std::logic_error("cyclic parent-child relationship detected")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the error case detected an error in Mir's logic? Or a problem with the runtime behaviour of a client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It detects a possible error in client logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BOOST_THROW_EXCEPTION(std::logic_error("cyclic parent-child relationship detected")); | |
BOOST_THROW_EXCEPTION(std::runtime_error("cyclic parent-child relationship detected")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Required to pass the new WLCS tests added by canonical/wlcs#277