-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support screen lockers #2959
Support screen lockers #2959
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2959 +/- ##
==========================================
- Coverage 78.40% 78.36% -0.04%
==========================================
Files 1053 1054 +1
Lines 71792 72051 +259
==========================================
+ Hits 56285 56465 +180
- Misses 15507 15586 +79
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The latest release of Swaylock works with this, but current master doesn't due to swaywm/swaylock#299. I have proposed swaywm/swaylock#300 to fix the problem on their side. It's also possible for us to add logic into |
Includes #2961 |
…when screen is locked
Rebased as that has landed, and wasn't set as the target |
222acca
to
b59b939
Compare
Note that on 22.04 (swaylock 1.5) we see: $ swaylock -f
2023-06-12 10:08:11 - [main.c:1186] Compositor does not support the input inhibitor protocol, refusing to run insecurely OTOH with 23.04 this works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks uncontentious.
The question is: do we want to delay landing until we have wlcs tests?
Personally, I'm fine with landing now. But need another opinion (especially as I've committed some "tidy up" to the branch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is: do we want to delay landing until we have wlcs tests?
No point letting it rot.
FYI swaywm/swaylock#300 landed so swaylock shouldn't break for us in future versions. |
Adds support for https://wayland.app/protocols/ext-session-lock-v1